Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct output order in parallel mode for iteration nodes #10323

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Nov1c444
Copy link
Contributor

@Nov1c444 Nov1c444 commented Nov 5, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

fix correct output order in parallel mode for iteration nodes

Fixes #9493

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 5, 2024
@Nov1c444 Nov1c444 requested a review from laipz8200 November 5, 2024 12:20
@dosubot dosubot bot added the 🐞 bug Something isn't working label Nov 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 6, 2024
@Nov1c444 Nov1c444 merged commit a7dbe58 into main Nov 8, 2024
10 checks passed
@Nov1c444 Nov1c444 deleted the fix/iteration-wrong-order branch November 8, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants