Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

celery worker log format following LOG_FORMAT env#9404 #10016

Merged
merged 10 commits into from
Nov 8, 2024

Conversation

liuhaoran1212
Copy link
Contributor

@liuhaoran1212 liuhaoran1212 commented Oct 29, 2024

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Celery worker log are output to the "LOG_FILE" env using "LOG_FORMAT" env, and use the "LOG_TZ" in env.

Fixes #9404

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Signed-off-by: root <root@localhost.localdomain>
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 29, 2024
@bowenliang123
Copy link
Contributor

Consider merging #9129 before this PR, changing the timezone into TimeZoneName type for easier use. cc @crazywoola @laipz8200

crazywoola
crazywoola previously approved these changes Oct 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@crazywoola crazywoola self-requested a review October 29, 2024 12:53
@crazywoola
Copy link
Member

Please fix the lint errors as well

Signed-off-by: root <root@localhost.localdomain>
root added 2 commits October 30, 2024 10:00
Signed-off-by: root <root@localhost.localdomain>
Signed-off-by: root <root@localhost.localdomain>
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

root added 2 commits October 31, 2024 16:38
@liuhaoran1212
Copy link
Contributor Author

After the Code was committed, it seems that CI was not triggered, it only shows "2 workflows awaiting approval", Please tell me what might be the reason for this, thanks. @crazywoola @bowenliang123

@bowenliang123
Copy link
Contributor

Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests.

@liuhaoran1212
Copy link
Contributor Author

Because this is your first ever PR in this repo, all workflows are executed only when the maintainer approves the runs. You may need a hand from @laipz8200 @crazywoola . Or you may test it locally and raise your screenshot evidence for passing the tests.

I understand now, thanks

@crazywoola
Copy link
Member

Please rebase the main branch and fix the errors again. :)

root and others added 2 commits November 8, 2024 09:04
crazywoola
crazywoola previously approved these changes Nov 8, 2024
@crazywoola crazywoola merged commit 7c2a9b0 into langgenius:main Nov 8, 2024
6 checks passed
@liuhaoran1212 liuhaoran1212 deleted the tag_celery branch November 8, 2024 09:14
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 14, 2024
)

Signed-off-by: root <root@localhost.localdomain>
Co-authored-by: root <root@localhost.localdomain>
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
)

Signed-off-by: root <root@localhost.localdomain>
Co-authored-by: root <root@localhost.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery worker log format not following "LOG_FORMAT" env
3 participants