[Refactor/Chore] AnalyticdbVector overrides parent class `BaseVector` in an inconsistent manner [bad-override]

[asukaminato0721]

Self Checks

• I have read the Contributing Guide and Language Policy.
• This is only for refactors or chores; if you would like to ask a question, please head to Discussions.
• I have searched for existing issues search for existing issues, including closed ones.
• I confirm that I am using English to submit this report, otherwise it will be closed.
• 【中文用户 & Non English User】请使用英语提交，否则会被关闭 ：）
• Please do not modify this template :) and fill in all the required fields.

Description

ERROR Class member `AnalyticdbVector.create` overrides parent class `BaseVector` in an inconsistent manner [bad-override]
  --> core/rag/datasource/vdb/analyticdb/analyticdb_vector.py:38:9
   |
38 |     def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs):
   |         ^^^^^^
   |
  `AnalyticdbVector.create` has type `(self: AnalyticdbVector, texts: list[Document], embeddings: list[list[float]], **kwargs: Unknown) -> None`, which is not assignable to `(self: AnalyticdbVector, texts: list[Document], embeddings: list[list[float]], **kwargs: Unknown) -> Never`, the type of `BaseVector.create`
  Signature mismatch:
  expected: def create(self: AnalyticdbVector, texts: list[Document], embeddings: list[list[float]], **kwargs: Unknown) -> Never: ...
                                                                                                                            ^^^^ return type
  found:    def create(self: AnalyticdbVector, texts: list[Document], embeddings: list[list[float]], **kwargs: Unknown) -> None: ...
                                                                                                                            ^^^ return type

Motivation

fix [bad-override]

Additional Context

No response

[asukaminato0721]

@dosu how to fix this

[dosubot]

The fix is straightforward - add an explicit -> None return type annotation to the BaseVector.create abstract method.

The issue is that the type checker (ty/pyrefly) is inferring -> Never for the base class method because it only contains raise NotImplementedError. When a function only raises an exception, type checkers infer Never as the return type since the function never actually returns.

Fix in vector_base.py:

@abstractmethod
def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs) -> None:
    raise NotImplementedError

This explicitly declares that the method should return None, which matches what all the concrete implementations actually do (AnalyticdbVector, MilvusVector, QdrantVector, WeaviateVector, ChromaVector, etc.).

Note: You may also want to add -> None to AnalyticdbVector.create and other subclass implementations for consistency, though this is optional once the base class has the annotation.

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[asukaminato0721]

ok, I will go to fix pyrefly @dosu

[dosubot]

Sounds good! Adding -> None to the base class method should resolve the type checker warning. Good luck with the fix! 👍

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[asukaminato0721]

@dosu facebook/pyrefly#2489 related pr is here

[dosubot]

Nice find! That PR fixes the root cause - pyrefly was incorrectly inferring Never for @abstractmethod methods that raise NotImplementedError. Once that lands, this warning should go away without needing any changes to Dify's codebase. Thanks for tracking this down upstream! 🎉

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}

   

[KinomotoMio]

Hi, I'd like to work on this issue. Could you please assign it to me?