feat(api): update API spec from langfuse/langfuse cb16277#1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Add
configfield toLlmConnectionandUpsertLlmConnectionRequestfor adapter-specific configurations, required for Bedrock and optional for VertexAI.configfield toLlmConnectionandUpsertLlmConnectionRequestfor adapter-specific configurations.configis required for Bedrock ({"region":"us-east-1"}) and optional for VertexAI ({"location":"us-central1"}); not used by other adapters.This description was created by
for 927e830. You can customize this summary. It will automatically update as commits are pushed.
Disclaimer: Experimental PR review
Greptile Overview
Greptile Summary
This PR adds a new optional
configfield to bothLlmConnectionandUpsertLlmConnectionRequestmodels to support adapter-specific configuration.Key Changes:
config: Optional[Dict[str, Any]]field toLlmConnectionmodel for storing adapter-specific configurationconfig: Optional[Dict[str, Any]]field toUpsertLlmConnectionRequestwith detailed validation rulesConfidence Score: 5/5
Important Files Changed
File Analysis
configfield for adapter-specific configuration (Bedrock region, VertexAI location)configfield with validation rules for Bedrock (required) and VertexAI (optional)Sequence Diagram
sequenceDiagram participant Client participant UpsertLlmConnectionRequest participant API participant LlmConnection Client->>UpsertLlmConnectionRequest: Create request with config Note over UpsertLlmConnectionRequest: config: Optional[Dict[str, Any]]<br/>Bedrock: {"region": "us-east-1"}<br/>VertexAI: {"location": "us-central1"} UpsertLlmConnectionRequest->>API: Submit upsert request API->>API: Validate config based on adapter Note over API: Bedrock: config required<br/>VertexAI: config optional<br/>Others: config not used API->>LlmConnection: Create/Update connection Note over LlmConnection: Store config for adapter-specific needs LlmConnection->>Client: Return connection (secrets masked)