fix(client): link dataset item positional arg#1062
Merged
Conversation
Contributor
There was a problem hiding this comment.
Disclaimer: Experimental PR review
PR Summary
Changes the order of parameters in the link method of DatasetItemClient class in /langfuse/client.py, making trace_or_observation the first positional argument.
- Reverts parameter order in
linkmethod to havetrace_or_observationas first positional argument instead ofrun_name - Could break existing code that relies on positional argument order rather than keyword arguments
- Affects dataset item linking functionality used to associate items with observations in dataset runs
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Reorder
trace_or_observationparameter inlink()inlangfuse/client.pyto be the first positional argument.trace_or_observationparameter inlink()inlangfuse/client.pyto be the first positional argument.link()to reflect the new parameter order.This description was created by
for 5e5e46f. It will automatically update as commits are pushed.