Add ingest settings to cloud connectors #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new 'tableStructure' setting to the IngestSettings interface and UI. - Updated the IngestSettings component to include a select input for the embedding model. - Improved layout and accessibility of input fields and switches. - Integrated default settings for chunk size, chunk overlap, OCR, picture descriptions, and embedding model from constants. - Implemented synchronization of settings with backend data using React Query.
deon-sanchez
changed the title
deon-sanchez
changed the title
deon-sanchez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the ingest settings functionality in the cloud picker UI by introducing a new option to capture table structure during knowledge ingest, improving the layout and usability of the settings panel, and ensuring the frontend settings are synchronized with backend defaults and user settings. The changes also refactor how settings are managed and displayed, making the UI more informative and robust.
New ingest settings feature:
tableStructureoption to the ingest settings, allowing users to enable capturing table structure during document ingest. This is reflected in the UI and type definitions (frontend/src/components/cloud-picker/ingest-settings.tsx,frontend/src/components/cloud-picker/types.ts,frontend/src/lib/constants.ts). [1] [2] [3]UI and usability improvements:
frontend/src/components/cloud-picker/ingest-settings.tsx).frontend/src/components/cloud-picker/unified-cloud-picker.tsx).Settings synchronization and management:
DEFAULT_KNOWLEDGE_SETTINGS) and synchronized with backend/user settings using React Query and context. MultipleuseEffecthooks ensure frontend state stays in sync with backend changes for chunk size, overlap, OCR, picture descriptions, and embedding model (frontend/src/components/cloud-picker/unified-cloud-picker.tsx,frontend/src/lib/constants.ts). [1] [2] [3]Code cleanup and consistency:
frontend/src/components/cloud-picker/ingest-settings.tsx).frontend/src/lib/constants.ts).