Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed duplicate controls from node toolbar #7274

Merged
merged 9 commits into from
Mar 30, 2025
Merged

fix: removed duplicate controls from node toolbar #7274

merged 9 commits into from
Mar 30, 2025

Conversation

lucaseduoli
Copy link
Collaborator

This pull request includes changes to the NodeToolbarComponent in the src/frontend/src/pages/FlowPage/components/nodeToolbarComponent/index.tsx file. The changes primarily involve removing certain toolbar items and their associated logic.

Key changes:

  • Removed the "Code" toolbar item and its associated logic.
  • Removed the "Advanced Settings" toolbar item and its associated logic.
  • Removed the "Freeze" toolbar item and its associated logic.

@lucaseduoli lucaseduoli requested a review from Cristhianzl March 25, 2025 19:49
@lucaseduoli lucaseduoli self-assigned this Mar 25, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. javascript Pull requests that update Javascript code labels Mar 25, 2025
@github-actions github-actions bot added the bug Something isn't working label Mar 25, 2025
Cristhianzl
Cristhianzl approved these changes Mar 25, 2025
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2025
@carlosrcoelho carlosrcoelho enabled auto-merge March 27, 2025 00:24
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 27, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 29, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 29, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 29, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 30, 2025
@carlosrcoelho carlosrcoelho added this pull request to the merge queue Mar 30, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 30, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 30, 2025
@lucaseduoli lucaseduoli added this pull request to the merge queue Mar 30, 2025
Merged via the queue into main with commit 5e39d3f Mar 30, 2025
22 checks passed
@lucaseduoli lucaseduoli deleted the fix/duplicate_controls branch March 30, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

Assignees

@lucaseduoli lucaseduoli

Labels
bug Something isn't working javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucaseduoli @Cristhianzl @carlosrcoelho