Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct issue 6216 with multiple IF-ELSE #7273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bkatya2001
Copy link

In the current implementation, the build_vertex method causes the inactive vertices to be reset for the first built IF-ELSE component. After that, the other components do not take into account that some vertices were inactive, which leads to incorrect operation of the entire flow.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Mar 25, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Mar 25, 2025
Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #7273 will degrade performances by 12.84%

Comparing bkatya2001:fix/6216 (2319202) with main (58e0d42)

Summary

❌ 2 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 8 ms 9 ms -10.89%
test_cancel_nonexistent_build 7.7 ms 8.9 ms -12.84%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant