Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate processing components #7254

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

edwinjosechittilappilly
Copy link
Collaborator

Screenshot 2025-03-25 at 3 34 38 AM

Parsers are deprecated in other PR.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates several processing components by marking them as legacy. It also includes reordering of import statements and minor whitespace adjustments in various test files to improve consistency.

  • Mark processing components as legacy via the new "legacy = True" flag.
  • Standardize import ordering within test files.
  • Introduce minor formatting changes to improve readability.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/backend/tests/unit/helpers/test_base_model_from_schema.py Reordered Pydantic import for consistency
src/backend/tests/unit/base/tools/test_toolmodemixin.py Added whitespace and consistent import ordering
src/backend/base/langflow/components/processing/merge_data.py Added "legacy = True" flag to mark legacy component
src/backend/tests/unit/mock_language_model.py Reordered Pydantic imports
src/backend/base/langflow/components/processing/filter_data.py Added "legacy = True" flag to mark legacy component
src/backend/base/langflow/components/processing/filter_data_values.py Added "legacy = True" flag to mark legacy component
src/backend/base/langflow/components/processing/combine_text.py Added "legacy = True" flag to mark legacy component
src/backend/tests/unit/inputs/test_inputs.py Added whitespace for improved formatting
src/backend/tests/unit/test_template.py Added whitespace for improved formatting
src/backend/tests/unit/base/tools/test_component_toolkit.py Added whitespace for consistent import ordering
src/backend/tests/unit/api/v1/test_api_schemas.py Added whitespace for consistent import ordering
src/backend/tests/unit/serialization/test_serialization.py Added whitespace for improved formatting
src/backend/tests/unit/graph/graph/state/test_state_model.py Added whitespace for consistent import ordering
src/backend/tests/unit/test_schema.py Added whitespace for improved formatting
src/backend/tests/unit/components/helpers/test_structured_output_component.py Reordered Pydantic import for consistency

Copy link

codspeed-hq bot commented Mar 25, 2025

CodSpeed Performance Report

Merging #7254 will degrade performances by 29.86%

Comparing deprecate_processing (8c8c9f6) with main (6c4828b)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 16 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cancel_build_unexpected_error 753.8 ms 614 ms +22.76%
test_cancel_build_with_cancelled_error 219.1 ms 258.9 ms -15.38%
test_cancel_nonexistent_build 8.4 ms 12 ms -29.86%

Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 25, 2025
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a replacement for all of those?

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Mar 25, 2025
@ogabrielluiz ogabrielluiz changed the title chore: deprecate processing components feat: deprecate processing components Mar 25, 2025
@github-actions github-actions bot added enhancement New feature or request and removed ignore-for-release labels Mar 25, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Mar 26, 2025
@edwinjosechittilappilly edwinjosechittilappilly added the DO NOT MERGE Don't Merge this PR label Mar 26, 2025
@edwinjosechittilappilly edwinjosechittilappilly marked this pull request as draft March 26, 2025 19:57
auto-merge was automatically disabled March 26, 2025 19:57

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't Merge this PR enhancement New feature or request size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants