-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate processing components #7254
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR deprecates several processing components by marking them as legacy. It also includes reordering of import statements and minor whitespace adjustments in various test files to improve consistency.
- Mark processing components as legacy via the new "legacy = True" flag.
- Standardize import ordering within test files.
- Introduce minor formatting changes to improve readability.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/backend/tests/unit/helpers/test_base_model_from_schema.py | Reordered Pydantic import for consistency |
src/backend/tests/unit/base/tools/test_toolmodemixin.py | Added whitespace and consistent import ordering |
src/backend/base/langflow/components/processing/merge_data.py | Added "legacy = True" flag to mark legacy component |
src/backend/tests/unit/mock_language_model.py | Reordered Pydantic imports |
src/backend/base/langflow/components/processing/filter_data.py | Added "legacy = True" flag to mark legacy component |
src/backend/base/langflow/components/processing/filter_data_values.py | Added "legacy = True" flag to mark legacy component |
src/backend/base/langflow/components/processing/combine_text.py | Added "legacy = True" flag to mark legacy component |
src/backend/tests/unit/inputs/test_inputs.py | Added whitespace for improved formatting |
src/backend/tests/unit/test_template.py | Added whitespace for improved formatting |
src/backend/tests/unit/base/tools/test_component_toolkit.py | Added whitespace for consistent import ordering |
src/backend/tests/unit/api/v1/test_api_schemas.py | Added whitespace for consistent import ordering |
src/backend/tests/unit/serialization/test_serialization.py | Added whitespace for improved formatting |
src/backend/tests/unit/graph/graph/state/test_state_model.py | Added whitespace for consistent import ordering |
src/backend/tests/unit/test_schema.py | Added whitespace for improved formatting |
src/backend/tests/unit/components/helpers/test_structured_output_component.py | Reordered Pydantic import for consistency |
CodSpeed Performance ReportMerging #7254 will degrade performances by 29.86%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a replacement for all of those?
Pull request was converted to draft
Parsers are deprecated in other PR.