-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Implement Lazy loading for as many icons as possible #7218
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good i only ask for some simple tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icons are glitching in the sidebar, when you enter the page for the first time. Even though they are already loaded, they glitch out. That's why I added most of the icons to the styleUtils import, in order for them to already load without having a quick loading state. Is it possible to fix that? If not, I would consider making all of the icons of the sidebar not to be lazy loaded, since all are used every time we open Langflow.
Lazy loads icons
Keeps the most used icons eager loaded
Testing:
Check out the network tab and filter by
.jsx
Browse the page and notice how icons are now loaded on an as need basis
Also be on the look out for any missing icons