Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement Lazy loading for as many icons as possible #7218

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

mfortman11
Copy link
Collaborator

@mfortman11 mfortman11 commented Mar 21, 2025

Lazy loads icons

Keeps the most used icons eager loaded

Testing:
Check out the network tab and filter by .jsx
Browse the page and notice how icons are now loaded on an as need basis

Also be on the look out for any missing icons

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Mar 21, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 21, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 25, 2025
@mfortman11 mfortman11 marked this pull request as ready for review March 25, 2025 22:17
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 25, 2025
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Mar 25, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 25, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 26, 2025
@mfortman11 mfortman11 requested a review from deon-sanchez March 26, 2025 15:04
Copy link
Collaborator

@deon-sanchez deon-sanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good i only ask for some simple tests.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 26, 2025
Copy link
Collaborator

@lucaseduoli lucaseduoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons are glitching in the sidebar, when you enter the page for the first time. Even though they are already loaded, they glitch out. That's why I added most of the icons to the styleUtils import, in order for them to already load without having a quick loading state. Is it possible to fix that? If not, I would consider making all of the icons of the sidebar not to be lazy loaded, since all are used every time we open Langflow.

@github-actions github-actions bot added the refactor Maintenance tasks and housekeeping label Mar 27, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 27, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
@mfortman11 mfortman11 enabled auto-merge March 28, 2025 04:03
@Cristhianzl Cristhianzl disabled auto-merge March 28, 2025 13:49
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
@github-actions github-actions bot added refactor Maintenance tasks and housekeeping and removed refactor Maintenance tasks and housekeeping labels Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer refactor Maintenance tasks and housekeeping size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants