Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix TypeScript issues with AI-ML component #6914

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: Fix TypeScript issues with AI-ML component #6914

wants to merge 7 commits into from

Conversation

TejasQ
Copy link
Contributor

@TejasQ TejasQ commented Mar 4, 2025

This PR addresses issue #6263 by fixing TypeScript issues in the codebase.

Changes:

  1. Converted AI-ML.jsx to AI-ML.tsx with proper TypeScript types
  2. Updated the index.tsx file to use proper TypeScript types with forwardRef
  3. Added proper type definitions for the component props

This should help reduce the TypeScript errors when running npm run type-check.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Mar 4, 2025
@TejasQ TejasQ mentioned this pull request Mar 4, 2025
Open
@ogabrielluiz ogabrielluiz requested a review from Cristhianzl March 6, 2025 16:19
Cristhianzl
Cristhianzl approved these changes Mar 24, 2025
View reviewed changes
Copy link
Member

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 24, 2025
@Cristhianzl Cristhianzl changed the title Fix TypeScript issues with AI-ML component fix: Fix TypeScript issues with AI-ML component Mar 24, 2025
@Cristhianzl Cristhianzl enabled auto-merge March 24, 2025 19:43
@github-actions github-actions bot added the bug Something isn't working label Mar 24, 2025
@Cristhianzl Cristhianzl added this pull request to the merge queue Mar 24, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2025
@carlosrcoelho carlosrcoelho added this pull request to the merge queue Mar 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TejasQ @Cristhianzl