Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement secret detection in log serialization #6724

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ogabrielluiz
Copy link
Contributor

Introduce secret detection during log serialization and validation, enhancing security by masking sensitive information. Add unit tests to ensure functionality and refactor the secret detection logic for better organization.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 20, 2025
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #6724 will degrade performances by 36.18%

Comparing redact-api-keys-logs (0e13c78) with main (af2d77d)

Summary

❌ 6 regressions
✅ 8 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow 238.2 ms 280.1 ms -14.97%
test_build_flow_from_request_data 248.9 ms 289.7 ms -14.1%
test_build_flow_invalid_job_id 8 ms 12.5 ms -36.18%
test_build_flow_polling 247.3 ms 288.4 ms -14.28%
test_build_flow_start_only 232.6 ms 346.6 ms -32.89%
test_build_flow_start_with_inputs 235.1 ms 274.5 ms -14.35%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants