Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to disable automatic superuser creation and streamline initialization #6082

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ogabrielluiz
Copy link
Contributor

Introduce a setting to disable automatic superuser creation, remove superuser initialization from the main flow, and refactor the initialization process for clarity and efficiency.

This might help worker issues because we were setting up the superuser more than one time. (Related to #6054)

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 3, 2025
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 3, 2025
Move import statements to function level to prevent circular dependencies in:
- src/backend/base/langflow/services/utils.py
- src/backend/base/langflow/services/database/service.py
- src/backend/tests/conftest.py

This change helps break circular import cycles by using local imports within functions.
@github-actions github-actions bot added enhancement New feature or request and removed enhancement New feature or request labels Feb 26, 2025
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #6082 will degrade performances by 12.51%

Comparing disable-superuser-create (58360f4) with main (7b3dc0b)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_build_flow_invalid_job_id 8.2 ms 9.4 ms -12.51%
test_cancel_nonexistent_build 13 ms 10.5 ms +23.77%

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants