[FEATURE] Migrate from Gson to Jackson #1042
Assignees
Labels
Comments
6 tasks
langchain4j
added a commit
that referenced
this issue
May 6, 2024
## Issue #1042 ## Change This is a first step for migrating LC4j from Gson to Jackson. This PR migrates Anthropic module only. Internal classes (which have to be public because Quarkus extension depends on them) are moved into `internal` packages. ## General checklist - [ ] There are no breaking changes - [ ] I have added unit and integration tests for my change - [X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green - [X] I have manually run all the unit and integration tests in the [core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core) and [main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j) modules, and they are all green - [ ] I have added/updated the [documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs) - [ ] I have added an example in the [examples repo](https://github.com/langchain4j/langchain4j-examples) (only for "big" features)
10 tasks
6 tasks
langchain4j
pushed a commit
that referenced
this issue
Jun 6, 2024
## Issue #1042 ## Change This PR migrates Mistral AI module only from Gson to Jackson according refactor plan. I've decided to begin with JSON migration before implement more breaking changes in Mistral AI module. @langchain4j take account that this PR is pre-requisite to implement Codestral fill-in-the-middle endpoint. [FIM feature](https://docs.mistral.ai/capabilities/code_generation/) will allow to the users define the starting point of the code using a `prompt`. FIM feature PR is waiting for this PR. ## General checklist <!-- Please double-check the following points and mark them like this: [X] --> - [ ] There are no breaking changes - [X] I have added unit and integration tests for my change - [X] I have manually run all the unit and integration tests in the module I have added/changed, and they are all green - [X] I have manually run all the unit and integration tests in the [core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core) and [main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j) modules, and they are all green <!-- Before adding documentation and example(s) (below), please wait until the PR is reviewed and approved. --> - [ ] I have added/updated the [documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs) - [ ] I have added an example in the [examples repo](https://github.com/langchain4j/langchain4j-examples) (only for "big" features)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
LangChain4j should use Jackson instead of Gson to better allign with Quarkus and Spring Boot ecosystem.
The text was updated successfully, but these errors were encountered: