Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split batches #469

Merged
merged 15 commits into from
Feb 23, 2024
Merged

Add split batches #469

merged 15 commits into from
Feb 23, 2024

Conversation

hinthornw
Copy link
Collaborator

No description provided.

str
The JSON formatted string.
"""
return orjson.dumps(obj, default=_serialize_json)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add some of the flags like serialize numpy etc etc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that applied before or after our default serialize json?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before I think

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ya otherwise the passthrough options wouldn't make sense. thanks

@hinthornw hinthornw merged commit 563dcb5 into main Feb 23, 2024
6 of 7 checks passed
@hinthornw hinthornw deleted the wfh/split_batches branch February 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants