This repository was archived by the owner on Jul 3, 2025. It is now read-only.
feat: attach custom tracer w/ replicas as callback #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc-arjun
commented
Jun 13, 2025
lc-arjun
changed the title
jacoblee93
reviewed
Jun 17, 2025
|
|
||
| if (run.langsmith_tracer) { | ||
| config.configurable ??= {}; | ||
| Object.assign(config.configurable, { |
There was a problem hiding this comment.
Why not do this in one line with a spread operator?
There was a problem hiding this comment.
its a fair question. tbh just copied from above lol
There was a problem hiding this comment.
nitpick` this is imo noisy, which is why I opted to do that instead
config.configurable = {
...config.configurable,
langsmith_project: run.langsmith_tracer.project_name,
langsmith_example_id: run.langsmith_tracer.example_id,
}
dqbd
reviewed
Jun 17, 2025
dqbd
reviewed
Jun 17, 2025
yarn.lock
Outdated
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "zod@npm:^3.25.32": |
dqbd
reviewed
Jun 17, 2025
| }, | ||
| "devDependencies": { | ||
| "@langchain/core": "^0.3.42", | ||
| "@langchain/core": "^0.3.59", |
There was a problem hiding this comment.
Does this warrant a bump on core?
There was a problem hiding this comment.
the replicas stuff won't work without the bump to core
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
replicasby defining alangchain_tracerwhen creating a run.