fix(cli): add monorepo commands to dockerfile#8391
Draft
hari-dhanushkodi wants to merge 1 commit into
Draft
Conversation
Co-authored-by: open-swe[bot] <open-swe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
--install-commandand--build-commandtolanggraph dockerfileand reuses the JS monorepo build-context logic fromlanggraph build, so generated Dockerfiles can install from the repo root while building from the LangGraph config directory.Release Note
langgraph dockerfilenow supports JS monorepo install/build commands.Test Plan
uv run --directory /workspace/langgraph/libs/cli pytest tests/unit_tests/cli/test_cli.py::test_dockerfile_command_nodejs_monorepo_commands tests/unit_tests/cli/test_cli.py::test_dockerfile_command_rejects_disallowed_nodejs_commands tests/unit_tests/test_config.py::test_config_to_docker_nodejsmake -C /workspace/langgraph/libs/cli formatmake -C /workspace/langgraph/libs/cli lintmake -C /workspace/langgraph/libs/cli test(blocked locally: Docker daemon unavailable for existing Docker-dependent tests)Made by Open SWE