feat: add str-fallback for custom types in msgpack serialization#7500
Draft
open-swe[bot] wants to merge 1 commit into
Draft
feat: add str-fallback for custom types in msgpack serialization#7500open-swe[bot] wants to merge 1 commit into
open-swe[bot] wants to merge 1 commit into
Conversation
Objects whose class defines __str__ (not inherited from object) are now serialized as EXT_CONSTRUCTOR_SINGLE_ARG with str(obj), enabling round-trip serde for types like bson.ObjectId without new dependencies. Co-authored-by: William FH <13333726+hinthornw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a duck-type fallback in
_msgpack_defaultfor objects that define a custom__str__method. Before raisingTypeErrorfor unserializable types, the serializer now checks if the object's class overrides__str__(i.e.,type(obj).__str__ is not object.__str__), and if so, stores(module, classname, str(obj))as anEXT_CONSTRUCTOR_SINGLE_ARG. This enables round-trip serialization of types likebson.ObjectIdwithout adding any new dependencies.Resolves https://forum.langchain.com/t/objectid-handling-by-msgpack-in-mongodb-checkpointer/3360
Test Plan
__str__(new test:test_serde_str_reconstructable_roundtrip)__str__still raise TypeError (new test:test_serde_str_fallback_not_triggered_for_plain_object)Opened collaboratively by William FH and open-swe.