fix: refactor injection logic to respect function signatures #6468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
The main purpose of this is to respect tool signatures that request injected args (like
ToolRuntime) even when the explicitly specifiedargs_schemadoes not.Ex in the following example, we should still inject
runtimedespite its absence inArgsSchemaThis is accompanied by langchain-ai/langchain#34051 which has tests that pass w/ this change. This tests injection w/
create_agent(more end to end than tests added in langchain-ai/langchain#33999.This unblocks the injection of
ToolRuntimeinto MCP tools which is exciting bc that exposes tool call id and state, which we previously were unable to do.other benefits
additional notes
ToolRuntime, hence having this logic here for now).args_schemaand not in the function signature (probably at the tool level though).