Skip to content

Conversation

@pokey
Copy link
Contributor

@pokey pokey commented Oct 3, 2025

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: fd28911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 3, 2025

@pokey is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Updated (UTC)
langchainjs-docs Ignored Ignored Oct 14, 2025 8:53am

Adds `bash_code_execution_tool_result` and `text_editor_code_execution_tool_result`
@pokey pokey force-pushed the pokey/fixanthropic-add-execution-tool-response-block-types branch from 2776620 to b7bf097 Compare October 3, 2025 14:33
@pokey
Copy link
Contributor Author

pokey commented Oct 3, 2025

Do we want an integration test?

@hntrl
Copy link
Member

hntrl commented Oct 3, 2025

yes that would be appreciated!

@pokey
Copy link
Contributor Author

pokey commented Oct 7, 2025

Re integration test, see #9109 (comment). Shall we merge this one in on the same basis?

pokey added a commit to pokey/langchainjs that referenced this pull request Oct 8, 2025
Anthropic has a bug where if we pass them back one of their bash_code_execution_output blocks which contains a file output, they return a 500. I have reported the error to them, but in the meantime this works around the problem by dropping the problematic content blocks before we send them to anthropic

Also adds an integration test that exercises this PR as well as:

- langchain-ai#9108
- langchain-ai#9109
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit 073e977 into langchain-ai:v1 Oct 14, 2025
32 checks passed
pokey added a commit to pokey/langchainjs that referenced this pull request Oct 14, 2025
Anthropic has a bug where if we pass them back one of their bash_code_execution_output blocks which contains a file output, they return a 500. I have reported the error to them, but in the meantime this works around the problem by dropping the problematic content blocks before we send them to anthropic

Also adds an integration test that exercises this PR as well as:

- langchain-ai#9108
- langchain-ai#9109
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants