Skip to content

Conversation

@urakozz
Copy link
Contributor

@urakozz urakozz commented Sep 4, 2025

Bump firebase-admin dependency

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025

⚠️ No Changeset found

Latest commit: 4353da2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 4, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
langchainjs-docs Ready Ready Preview Comment Sep 5, 2025 7:11pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Sep 5, 2025 7:11pm

Copy link
Member

@hntrl hntrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @urakozz!

One thing -- I think we'll need to bump this in peerDependencies if we're upgrading the dep

https://github.com/langchain-ai/langchainjs/pull/8846/files#diff-252ebd2576253f53ca111235c69d74ae803b12621d671319d9edd5ceb0188dc5R312

@urakozz
Copy link
Contributor Author

urakozz commented Sep 5, 2025

@hntrl yes sure, it accidentally slipped out of my attention :) I see Aritable connector is failing on Ubuntu 18, but its logic seems to be far from firebase-admin, I'm not sure if it was my change that caused that 🤔. Also, Locally on macOS and Ubuntu 24 tests passed

@hntrl hntrl force-pushed the firebase-admin-peer-depedency-bump branch from 669fa08 to 4353da2 Compare September 5, 2025 18:55
@hntrl hntrl changed the base branch from main to hunter/fix/milvus-mocks September 5, 2025 18:57
@hntrl hntrl deleted the branch langchain-ai:hunter/fix/milvus-mocks September 5, 2025 18:59
@hntrl hntrl closed this Sep 5, 2025
@urakozz urakozz deleted the firebase-admin-peer-depedency-bump branch September 5, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants