feat(community): Remove required param from LanceDB integration #6706

AyushExel · 2024-09-06T08:11:39Z

Hello. I'm from LanceDB team. The integration used old version of lancedb and user had to create a table with dummy data in order to ingest stuff. This makes passing Table optional. If not found, the integration will automatically create table if not passed by the user, making it easier to work with LanceDB<>Langchain.

vercel · 2024-09-06T08:11:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Sep 17, 2024 2:30am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	⬜️ Ignored (Inspect)			Sep 17, 2024 2:30am

AyushExel · 2024-09-09T15:24:19Z

Hey @jacoblee93 can you please take a look at this? Its been requested to improve UX from our community users. Thanks in advance!

jacoblee93 · 2024-09-10T20:55:47Z

Apologies for the delay, having a look now!

…to 6706

libs/langchain-community/src/vectorstores/lancedb.ts

jacoblee93 · 2024-09-10T21:03:38Z

Thanks for this!

Ran yarn format and updated naming for consistency.

jacoblee93 · 2024-09-10T22:13:50Z

Hey @AyushExel, this is failing CI:

Error: src/vectorstores/lancedb.ts(89,9): error TS2769: No overload matches this call.
  Overload 1 of 5, '(name: string, data: Record<string, unknown>[] | Table<any>, options: WriteOptions): Promise<Table<number[]>>', gave the following error.
    Type 'string' is not assignable to type 'WriteMode | undefined'.
  Overload 2 of 5, '(name: string, data: Record<string, unknown>[] | Table<any>, embeddings: EmbeddingFunction<number[]>): Promise<Table<number[]>>', gave the following error.
    Argument of type '{ writeMode: string; }' is not assignable to parameter of type 'EmbeddingFunction<number[]>'.
      Object literal may only specify known properties, and 'writeMode' does not exist in type 'EmbeddingFunction<number[]>'.

Could you have a look?

AyushExel · 2024-09-11T15:53:40Z

@jacoblee93 Updated! Can you take a look again? Thanks!

jacoblee93 · 2024-09-11T20:52:07Z

Thank you!

AyushExel · 2024-09-13T01:53:13Z

@jacoblee93 okay tested the examples folder locally. Needed to update lancedb package version there as well. should be working now

jacoblee93 · 2024-09-16T23:56:41Z

Hey sorry got super busy with releasing everything for 0.3 - will have a look at this today!

…to 6706

jacoblee93 · 2024-09-17T02:12:05Z

Thank you for your patience! Will ship this tonight.

jacoblee93 · 2024-09-17T05:25:22Z

Live in community@0.3.1!

AyushExel · 2024-09-17T16:20:25Z

Awesome thanks!

…chain-ai#6706) Co-authored-by: jacoblee93 <jacoblee93@gmail.com>

* Create llm and embeddings implementation, include tests (#1) * Initiate repo, start creating llm solution: generate and stream created * Exclude authentication outside of the file * Allow generating text on deployed models, make changes according authentication exclusion * Extract types outside of llms, small change * start working on embeddings. create simple tests * Add some features, rework llm * Add embeddings * Create tests for llms and embeddings * Small fixes * Adjust to sdk new package * Rename variables * Add README.md file * Rename variables --------- Co-authored-by: FIlip Żmijewski <filipzmijewski@filips-mbp.krakow.pl.ibm.com> * Add dependencies * fix(langchain): Fix local file store traversal issue (langchain-ai#6736) * fix(ci): Fix cf exports test (langchain-ai#6737) * fix(ci): Fix cf-workers export test (langchain-ai#6738) * fix(ci): Fix esbuild tests (langchain-ai#6739) * fix(ci): Fix ci (langchain-ai#6741) * chore(langchain): Release 0.2.19 * fix(langchain): Prevent exception when using plan & execute agent with no tools (langchain-ai#6744) Co-authored-by: Brace Sproul <braceasproul@gmail.com> * fix(openai): Avoid thrown error on o1 stream calls (langchain-ai#6747) * chore(openai): Release 0.2.11 (langchain-ai#6748) * docs: Update link (langchain-ai#6757) * refactor: Move langchain/core to a peer dep (langchain-ai#6698) Co-authored-by: Brace Sproul <braceasproul@gmail.com> Co-authored-by: Erick Friis <erick@langchain.dev> * chore(core): Release 0.3.0 (langchain-ai#6760) * chore(deps): Update deps for 0.3.0 (langchain-ai#6761) * chore(textsplitters): Release 0.1.0 (langchain-ai#6762) * chore(cloudflare): Bump dep (langchain-ai#6763) * chore(openai): Release 0.3.0 (langchain-ai#6764) * chore(anthropic): Release 0.3.0 (langchain-ai#6765) * chore(mistralai): Release 0.1.0 (langchain-ai#6766) * chore(langchain): Release 0.3.0 * chore(build): Update lock (langchain-ai#6770) * chore(cohere): Release 0.3.0 (langchain-ai#6771) * chore(weaviate): Release 0.1.0 (langchain-ai#6773) * chore(aws): Release 0.1.0 (langchain-ai#6775) * chore(azure-cosmosdb): Release 0.2.0 (langchain-ai#6776) * chore(azure-dynamic-sessions): Release 0.2.0 (langchain-ai#6777) * chore(release): Release Baidu, Exa, MixedBread, Nomic (langchain-ai#6778) * fix(ci): Fix CI issue where local monorepo node_modules were copied into export tests (langchain-ai#6774) * chore(community): Release 0.3.0 (langchain-ai#6779) * chore(cloudflare): Release 0.1.0 (langchain-ai#6780) * chore(groq): Release 0.1.1 (langchain-ai#6781) * chore(mongodb): Release 0.1.0 (langchain-ai#6782) * chore(ollama): Release 0.1.0 (langchain-ai#6783) * chore(pinecone): Release 0.1.0 (langchain-ai#6784) * chore(qdrant): Release 0.1.0 (langchain-ai#6785) * chore(redis): Release 0.1.0 (langchain-ai#6786) * chore(google): Release 0.1.0 (langchain-ai#6787) * chore(google-genai): Release 0.1.0 (langchain-ai#6788) * fix(core, langchain): Update langsmith dep to rc (langchain-ai#6797) * chore(core): Release 0.3.1 (langchain-ai#6800) * Release 0.3.1 * fix(langchain): Remove circular peer dep in langchain on @langchain/community (langchain-ai#6803) * chore(langchain): Release 0.3.2 (langchain-ai#6805) * docs: new algolia index (langchain-ai#6810) * docs: Adds 0.3 versioning docs (langchain-ai#6793) * docs: NotFound page suggested links (langchain-ai#6809) Co-authored-by: jacoblee93 <jacoblee93@gmail.com> * docs: Fix Firecrawl v0 version in the docs (langchain-ai#6768) * docs: Fix concepts docs hash param (langchain-ai#6816) * fix(google): Fixed - TypeError: Cannot read properties of undefined (reading 'generationInfo') (langchain-ai#6756) * fix(ci): Conditionally deplpy api refs to prod (langchain-ai#6819) * fix(ci): Add vercel ignore file (langchain-ai#6820) * feat(google-common): Export ChatConnection class (langchain-ai#6823) * chore(google-common): Release 0.1.1 (langchain-ai#6824) * fix(core,langchain,community): Update LangSmith deps, lighten export tests (langchain-ai#6825) * deps: update @anthropic-ai/sdk to 0.27.3 from 0.25.2 (langchain-ai#6796) Co-authored-by: jacoblee93 <jacoblee93@gmail.com> * chore(anthropic): Release 0.3.1 (langchain-ai#6826) * docs: Adds warnings to cypher chain about credentials (langchain-ai#6827) * feat(community): Remove required param from LanceDB integration (langchain-ai#6706) Co-authored-by: jacoblee93 <jacoblee93@gmail.com> * fix(ci): Fix lint (langchain-ai#6828) * chore(community): Release 0.3.1 (langchain-ai#6831) * fix(ci): Update API ref deployment action & vercelignore (langchain-ai#6835) * fix(core): Fix nested stream events behavior (langchain-ai#6836) * chore(core): Release 0.3.2 (langchain-ai#6839) * fix(ci): Add script for aliasing domains in gh deployments (langchain-ai#6838) * chore(deps): bump the pip group across 1 directory with 2 updates (langchain-ai#6840) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(groq): Feature/groq response format improvements (langchain-ai#6754) Co-authored-by: jacoblee93 <jacoblee93@gmail.com> * fix(core): Loosen return type of withConfig, fix tracing for nested tool calls (langchain-ai#6847) * chore(core): Release 0.3.3 (langchain-ai#6848) * docs(tutorial): fix typo (langchain-ai#6849) * fix(mistral): Fix call options type (langchain-ai#6857) * chore(mistralai): Release 0.1.1 (langchain-ai#6858) * fix: typo fix in agents doc (langchain-ai#6859) * feat(community): Update ChromeLLM with latest experimental API (langchain-ai#6861) * chore(community): Release 0.3.2 (langchain-ai#6862) * fix(community): bump `@upstash/ratelimit` version (langchain-ai#6832) Co-authored-by: bracesproul <braceasproul@gmail.com> * fix(docs): Drop announcement bar (langchain-ai#6863) * groq[patch]: set api key attr (langchain-ai#6864) Co-authored-by: jacoblee93 <jacoblee93@gmail.com> * chore(groq): Release 0.1.2 (langchain-ai#6865) * chore(openai,anthropic): Expose OpenAI and Anthropic payload formatters (langchain-ai#6872) * chore(openai): Release 0.3.1 (langchain-ai#6874) * chore(anthropic): Release 0.3.2 (langchain-ai#6875) * feat(anthropic,openai): Add payload formatting utils to Anthropic and OpenAI (langchain-ai#6876) * chore(openai): Release 0.3.2 (langchain-ai#6877) * chore(anthropic): Release 0.3.3 (langchain-ai#6878) * community[patch]: support AWS_... env vars (langchain-ai#6866) * chore(community): Release 0.3.3 (langchain-ai#6880) * Fix yarn.lock file --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: FIlip Żmijewski <filipzmijewski@filips-mbp.krakow.pl.ibm.com> Co-authored-by: Jacob Lee <jacoblee93@gmail.com> Co-authored-by: oleg <me@olegivaniv.com> Co-authored-by: Brace Sproul <braceasproul@gmail.com> Co-authored-by: Erick Friis <erick@langchain.dev> Co-authored-by: Nicolas <nicolascamara29@gmail.com> Co-authored-by: Prakash Pokharel <pksharmapokhrel@gmail.com> Co-authored-by: Lab Rat <35325046+rootCircle@users.noreply.github.com> Co-authored-by: Ayush Chaurasia <ayush.chaurarsia@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Herman Hrand <54174661+allohamora@users.noreply.github.com> Co-authored-by: jjangga0214 <bnbcmindnpass@gmail.com> Co-authored-by: Stephen M Abbott <stephenabbott20@gmail.com> Co-authored-by: Cahid Arda Öz <cahidardaooz@hotmail.com> Co-authored-by: Bagatur <22008038+baskaryan@users.noreply.github.com>

AyushExel added 4 commits September 6, 2024 11:57

update lancedb integration

25ec9ff

update docs

5d8de1c

update

c94a4eb

Merge branch 'langchain-ai:main' into main

29b9cce

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 6, 2024

vercel bot had a problem deploying to Preview – langchainjs-docs September 6, 2024 08:11 Failure

dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Sep 6, 2024

Merge branch 'main' into main

06da78a

vercel bot had a problem deploying to Preview – langchainjs-docs September 8, 2024 09:00 Failure

Merge branch 'main' of https://github.com/langchain-ai/langchainjs in…

3e3fd38

…to 6706

jacoblee93 changed the title ~~Update LanceDB integration~~ feat(community): Update LanceDB integration Sep 10, 2024

jacoblee93 changed the title ~~feat(community): Update LanceDB integration~~ feat(community): Remove required param from LanceDB integration Sep 10, 2024

Format examples

14384b1

jacoblee93 reviewed Sep 10, 2024

View reviewed changes

libs/langchain-community/src/vectorstores/lancedb.ts Outdated Show resolved Hide resolved

jacoblee93 reviewed Sep 10, 2024

View reviewed changes

libs/langchain-community/src/vectorstores/lancedb.ts Outdated Show resolved Hide resolved

Update lock

d7ca3ca

jacoblee93 approved these changes Sep 10, 2024

View reviewed changes

dosubot bot added the lgtm PRs that are ready to be merged as-is label Sep 10, 2024

vercel bot deployed to Preview – langchainjs-docs September 10, 2024 21:13 View deployment

fix type

71003c6

vercel bot deployed to Preview – langchainjs-docs September 11, 2024 15:42 View deployment

Merge branch 'main' into main

107744c

vercel bot deployed to Preview – langchainjs-docs September 11, 2024 15:55 View deployment

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 13, 2024

AyushExel added 2 commits September 13, 2024 07:22

lint

6c95ac1

Merge branch 'main' into main

e9fe36e

vercel bot had a problem deploying to Preview – langchainjs-docs September 13, 2024 01:54 Failure

Merge branch 'main' into main

89f7e6f

vercel bot had a problem deploying to Preview – langchainjs-docs September 13, 2024 17:54 Failure

Merge remote-tracking branch 'upstream/main'

15a2167

vercel bot had a problem deploying to Preview – langchainjs-docs September 14, 2024 11:13 Failure

Merge branch 'main' into main

00ae510

vercel bot had a problem deploying to Preview – langchainjs-docs September 15, 2024 14:34 Failure

Merge branch 'main' into main

fdd4006

vercel bot had a problem deploying to Preview – langchainjs-docs September 16, 2024 06:12 Failure

Merge branch 'main' into main

ba67366

vercel bot had a problem deploying to Preview – langchainjs-docs September 16, 2024 12:11 Failure

jacoblee93 added 2 commits September 16, 2024 19:11

Merge branch 'main' of https://github.com/langchain-ai/langchainjs in…

96b7def

…to 6706

Update lock

3a3a6b2

vercel bot deployed to Preview – langchainjs-docs September 17, 2024 02:20 View deployment

Fix lint

9a6aa4c

vercel bot deployed to Preview – langchainjs-docs September 17, 2024 02:30 View deployment

jacoblee93 merged commit 615b9d9 into langchain-ai:main Sep 17, 2024
35 checks passed

FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Sep 27, 2024

feat(community): Remove required param from LanceDB integration (lang…

42ea1dd

…chain-ai#6706) Co-authored-by: jacoblee93 <jacoblee93@gmail.com>

FilipZmijewski pushed a commit to FilipZmijewski/langchainjs that referenced this pull request Sep 27, 2024

feat(community): Remove required param from LanceDB integration (lang…

bc676bc

…chain-ai#6706) Co-authored-by: jacoblee93 <jacoblee93@gmail.com>

langchain-ai locked as spam and limited conversation to collaborators Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(community): Remove required param from LanceDB integration #6706

feat(community): Remove required param from LanceDB integration #6706

AyushExel commented Sep 6, 2024

vercel bot commented Sep 6, 2024 •

edited

Loading

AyushExel commented Sep 9, 2024

jacoblee93 commented Sep 10, 2024

jacoblee93 commented Sep 10, 2024 •

edited

Loading

jacoblee93 commented Sep 10, 2024

AyushExel commented Sep 11, 2024 •

edited

Loading

jacoblee93 commented Sep 11, 2024

AyushExel commented Sep 13, 2024

jacoblee93 commented Sep 16, 2024

jacoblee93 commented Sep 17, 2024

jacoblee93 commented Sep 17, 2024

AyushExel commented Sep 17, 2024

feat(community): Remove required param from LanceDB integration #6706

feat(community): Remove required param from LanceDB integration #6706

Conversation

AyushExel commented Sep 6, 2024

vercel bot commented Sep 6, 2024 • edited Loading

AyushExel commented Sep 9, 2024

jacoblee93 commented Sep 10, 2024

jacoblee93 commented Sep 10, 2024 • edited Loading

jacoblee93 commented Sep 10, 2024

AyushExel commented Sep 11, 2024 • edited Loading

jacoblee93 commented Sep 11, 2024

AyushExel commented Sep 13, 2024

jacoblee93 commented Sep 16, 2024

jacoblee93 commented Sep 17, 2024

jacoblee93 commented Sep 17, 2024

AyushExel commented Sep 17, 2024

vercel bot commented Sep 6, 2024 •

edited

Loading

jacoblee93 commented Sep 10, 2024 •

edited

Loading

AyushExel commented Sep 11, 2024 •

edited

Loading