Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[minor]: Support storing and retrieving Document id field in MemoryVectorStore #6572

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

dschenkelman
Copy link
Contributor

@dschenkelman dschenkelman commented Aug 19, 2024

Fixed #6577

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 19, 2024
Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Aug 22, 2024 9:52pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Aug 22, 2024 9:52pm

@dschenkelman
Copy link
Contributor Author

Hey team, what's the best way to get feedback on this one?

Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. If CI passes I can get it merged in. Thank you

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Aug 22, 2024
@bracesproul bracesproul changed the title Support storing and retrieving Document id field in MemoryVectorStore langchain[minor]: Support storing and retrieving Document id field in MemoryVectorStore Aug 22, 2024
@dschenkelman
Copy link
Contributor Author

happy to help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MemoryVectorStore does not support Document id property
2 participants