Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Adds support for Bedrock Anthropic tool streaming #6070

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jacoblee93
Copy link
Collaborator

Copy link

vercel bot commented Jul 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:10am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2024 4:10am

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Jul 16, 2024
@@ -556,145 +558,122 @@ export class BedrockChat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that this PR introduces a new external HTTP request using the _signedFetch method. I've flagged this change for your review to ensure it aligns with the project's requirements. Let me know if you have any questions or need further clarification!

@@ -485,3 +486,46 @@ test.skip(".bindTools with openai tool format", async () => {
const { tool_calls } = response;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the recent change in the code explicitly accesses environment variables using process.env. I've flagged this for your review to ensure proper handling of environment variables. Let me know if you need further assistance with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant