Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch]: Fix PostgresRecordManager table being created with name 'undefined' #5796

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

MJDeligan
Copy link
Contributor

The final table name is computed from the table name that is passed in the config which is an optional field. When no table name is explicitly passed, the final table name becomes undefined. This PR fixes the bug by using the correct tableName property, which is initialized with a fallback value.

Note: This is technically breaking for anyone who started using the api after the schema support was added.

Fixes #5795

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 18, 2024 9:53am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 18, 2024 9:53am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jun 18, 2024
@jacoblee93 jacoblee93 changed the title Fix PostgresRecordManager table being created with name 'undefined' community[patch]: Fix PostgresRecordManager table being created with name 'undefined' Jun 18, 2024
@jacoblee93
Copy link
Collaborator

Agh, thanks. I think worth it

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Jun 18, 2024
@jacoblee93 jacoblee93 merged commit 4c7092d into langchain-ai:main Jun 18, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgresRecordManager creates table named undefined
2 participants