Unstructured in memory loader #5726
Conversation
sync main
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -29,6 +30,34 @@ test.skip("Test Unstructured base loader", async () => { | |||
| } | |||
There was a problem hiding this comment.
Hey team, just wanted to flag this PR for review as it includes changes that access an environment variable via process.env to obtain the API key for the options object. Please take a look and ensure everything is handled securely. Thanks!
| @@ -167,20 +179,28 @@ export class UnstructuredLoader extends BaseDocumentLoader { | |||
| private maxCharacters?: number; | |||
There was a problem hiding this comment.
Hey there! I've reviewed the code and noticed that the recent change in the unstructured.ts file accesses an environment variable using getEnvironmentVariable. I've flagged this for your review to ensure it aligns with the intended functionality. Let me know if you need further assistance!
| @@ -29,6 +30,34 @@ test.skip("Test Unstructured base loader", async () => { | |||
| } | |||
There was a problem hiding this comment.
Hey team, I've flagged this PR for your review as it adds code that explicitly accesses an environment variable via process.env. Please take a look to ensure that the handling of environment variables aligns with best practices and security guidelines.
|
great I think you can close my PR, thanks for help with linting🔥 |
|
Thank you! |
Builds off of #5581 with lint and docs
CC @andrewdoro