google-vertexai[minor] Add standard tests #5721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XL
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -0,0 +1,58 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey team, I've reviewed the code and noticed that the new changes are accessing environment variables via process.env. I've flagged this for your attention to ensure it aligns with our best practices. Let me know if you need any further assistance with this.
| @@ -0,0 +1,35 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey team, just a heads up that I've flagged a change in the PR that explicitly adds an environment variable via process.env. This is for your review to ensure it aligns with our best practices. Let me know if you have any questions!
dosubot
bot
added
size:XXL
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.