Add schema support for ensureTableInDatabase

[n1md7]

Added schema name to override it when needed.

It's backward-compatible and should not break existing functionality.

Fixes #4503

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
langchainjs-api-refs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 29, 2024 9:47pm
langchainjs-docs	✅ Ready (Inspect)	Visit Preview		Feb 29, 2024 9:47pm

[jacoblee93]

Thank you!

[jacoblee93]

Oh hey - should this be in quotes like this?

#4480

[MJDeligan]

Would setting the default schema like this not be breaking for users who've set a search path other than "public" ?

[n1md7]

Oh hey - should this be in quotes like this?

#4480

I'll change it

[n1md7]

Would setting the default schema like this not be breaking for users who've set a search path other than "public" ?

I'll verify that

@MJDeligan Yes, you are right.
It will break existing code unless an appropriate schema is specified while instantiating TypeORMVectorStore.

The example below overrides schema just fine

await store.appDataSource.query(`set search_path=${schema}`);
await store..ensureTableInDatabase();

I guess this PR is no longer needed.

[jacoblee93]

We could use a different query based on the presence/absence of schemaName? I think that would be the way to go.

Sort of like this: #4543

[jacoblee93]

And thanks for flagging @MJDeligan!

[n1md7]

We could use a different query based on the presence/absence of schemaName? I think that would be the way to go.

Sort of like this: #4543

Oh right, so when the schema is present I prepend it with the table name otherwise it stays as it is.

[MJDeligan]

Looks good! I'm not familiar with TypeORM. How does it know to use the schema for the other operations? Would that have to passed as part of the postgres connection options?

[n1md7]

Looks good! I'm not familiar with TypeORM. How does it know to use the schema for the other operations? Would that have to passed as part of the postgres connection options?

Yes, in TypeORM schema can be specified when driver is Postgres. When it's omitted it fallbacks to public at least in most cases but the logic can be seen here https://github.com/typeorm/typeorm/blob/master/src/driver/postgres/PostgresDriver.ts#L360

[n1md7]

@jacoblee93 wdyt?