community[patch]: Allow using a pool for PostgresRecordManager #4409
Conversation
Enable to use a predefined pool for PostgresRecordManager, allowing to use multiple indices per database. Without, each index will create a new pool, leading to Postgres connection exhaustion.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
| this.namespace = namespace; | ||
| this.pool = new pg.Pool(postgresConnectionOptions); | ||
| if (pool instanceof Pool) { |
There was a problem hiding this comment.
violates eslint rule. checking that pool is not undefined should be fine
| } else { | ||
| try { | ||
| this.pool = new pg.Pool(postgresConnectionOptions); | ||
| } catch (err: unknown) { |
There was a problem hiding this comment.
pool constructor does not throw when config is undefined/invalid as far as I can tell. checking that pool and config aren't both undefined should work
|
@MJDeligan Thanks, you're right, that code could be improved. :) Since I posted I'm not anymore sure what's the best way to handle the problem that connections are held for a long time. Could also be a problem in the code calling the RecordManager not closing it. (A hint for that in the examples would be really nice). |
|
@mkesper I think you're right that having multiple pools will lead to the creation of too many clients. Being able to pass your own pool is definitely good. Not ending the pool(s) will of course worsen this. Sorry about the documentation, the long example is a little unwieldy. Maybe a very minimal example at the beginning would be good to add. |
|
Thank you for the review @MJDeligan! I think technically the instanceof check is ok here (with a linter ignore) because it's Node only. Have seen instanceof checks be unreliable in environments that use bundlers like Next.js since you can wind up with multiple declarations in different chunks. But probably best to avoid yes. |
jacoblee93
changed the title
Enable to use a predefined pool for PostgresRecordManager, allowing to use multiple indices per database. Without, each index will create a new pool, leading to Postgres connection exhaustion.
Fixes #4407