Added async progres checker function in refineDocuments chain #3591
Conversation
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
|
@jacoblee93 Sure. Updated |
2. progress value trimmed to 2 decimal point
| @@ -439,6 +443,10 @@ export class RefineDocumentsChain | |||
| runManager?.getChild("refine") | |||
| ); | |||
| refineSteps.push(res); | |||
| if (this.onDocumentProcessed) { | |||
| const progress = (i / currentDocs.length).toFixed(2); // Progress calculation | |||
| await this.onDocumentProcessed(Number(progress)); // Emitting the progress | |||
There was a problem hiding this comment.
Ah, was also suggesting that this emits the actual document in addition to just a fraction. User could calculate a progress meter on their own.
Let's actually hold off on this though - we're starting to look more at these older chains to see how we can modernize them more with LCEL principles.
There was a problem hiding this comment.
Right, instead of calculating and returning the progress, would make more sense to return the document itself,
and maybe the current loop number, It'd allow more freedom in the code side.
I understand that this is currently on hold to adapt and implement in LECL way, any tentative plan for when is this feature might be picked up? (I kind of need this for my project)
Thanks
There was a problem hiding this comment.
So sorry for missing this reply - could this work with the existing callback system by adding a handleLLMEnd callback to the model?
https://js.langchain.com/docs/modules/callbacks/how_to/create_handler
Improvement made in the Document Refine Chain. This will help show the progress it has made on the refinement process.