-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added GraphQLClientTool #3091
base: main
Are you sure you want to change the base?
Added GraphQLClientTool #3091
Conversation
langchain/src/tools/graphql.ts
Outdated
@@ -0,0 +1,41 @@ | |||
import { z } from "zod"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new HTTP request using the fetch
function. Please review this change to ensure it aligns with the project's requirements and best practices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Similar to your Python interpreter one we've started flagging to folks that the LLM could generate arbitrary mutations, and that this should live under experimental
with a security warning. Would you mind moving?
Sure! Will follow up on both some time this week |
I have moved the tool under tools/experimental. Where should I put the docs and the warning now? |
@mishushakov This works pretty well for my purposes, however when I use it as part of a Unfortunately, I only started using langchain a couple of days ago so I don't really know if that's expected for that type of agent, or if something else is required. Any help is appreciated! |
Glad to hear that! Variables aren't required, so I should probably make it optional as you suggested 😀 |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looks good - sounds like you're going to address @qnm's feedback though? |
Yep and I believe I'd need to update the unit test here as well |
I have updated the tool, tests and moved it to experimental/tools now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Looks good to me once my comments have been implemented!
Hello and Merry Christmas! I have done so in the latest commit |
Yo @bracesproul & @jacoblee93, would you be able to review? Thank you so much 😊 |
I have added a GraphQL client tool to execute graphql requests.
Example: