Document: Explicitly check that pageContents is not an empty string. #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
skarard
changed the title
|
Ideally we shouldn't need this with TypeScript, but an empty string should be permissible, just not a hard |
|
Sure I change this out to allow it to record an empty string.
…On Mon, 9 Oct 2023, 18:41 Jacob Lee, ***@***.***> wrote:
Ideally we shouldn't need this with TypeScript, but an empty string should
be permissible, just not a hard undefined, null, or non-string value -
can you change?
—
Reply to this email directly, view it on GitHub
<#2836 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAES7ZPDXG2I724JOIJLWXLX6QZMBAVCNFSM6AAAAAA5XQOJCWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGQYDQMBXHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@jacoblee93 I added the proposed change and threw in a couple of unit tests for good measure. |
bracesproul
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Hey @skarard sorry for taking so long to review, these changes look good! We've moved document.ts into langchain-core/src/documents/document.ts, could you push up a change moving your changes into that updated file then re-request my review?
Thanks again!
…cument-constructor-throw-on-empty-pageContent
dosubot
bot
added
the
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to a discussion in #2807, the current behaviour of the Document constructor
field.pageContentwhen given an empty string is to setpageContentasundefined. This brokeHNSWLib.addDocuments()as it attempts a string.replace() onundefinedrather than the typedstringexpected.I suggested allowing
pageContentsto be set as an empty string. @jacoblee93 suggested that a Document with an emptypageContentsshould not be created at all.This implementation requires
pageContentsto be a string that is not empty, otherwise it throwsError("pageContents must not be empty").