Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not passing: jsdomexception issue #3

Closed
lalalune opened this issue Feb 15, 2023 · 1 comment · Fixed by #11
Closed

Tests are not passing: jsdomexception issue #3

lalalune opened this issue Feb 15, 2023 · 1 comment · Fixed by #11

Comments

@lalalune
Copy link

lalalune commented Feb 15, 2023

Currently the agent test is failing because of an issue with the serpapi package and jest, specifically inside of a package inside of another package (jsdom -> jsdomexceptions).

It's possible that it's a tsconfig thing but I couldn't find any information to suggest it was anything but a bad line of code or something that isn't well supported in node.

Solution ideas:

  1. Write a script that edits the package to fix the error. Not great, but fast and works.

  2. Switch to serp npm package

  3. work with the developer on serpapi to get it resolved?

@sebastianquek
Copy link

sebastianquek commented Feb 15, 2023

See serpapi/serpapi-javascript#10,

I've updated serpapi to 1.1.1 which removes the production dependency on domexception. Let me know if you're still facing issues after the update. Will close this for now.

Nonetheless, I still think setting preset-env to target the current node version makes sense since this is meant to be ran in a node environment 🙂

jacoblee93 pushed a commit that referenced this issue Aug 25, 2023
* update MyScale metric_type to case sensitive

* Update get_started.mdx (#3)

* Update get_started.mdx

---------

Co-authored-by: Nearzxh <270761322@qq.com>
Co-authored-by: Xiaohua Zhang <xiaohuaz@moqi.ai>
jacoblee93 pushed a commit that referenced this issue Dec 6, 2023
sinedied pushed a commit to sinedied/langchainjs that referenced this issue Jun 10, 2024
…angchain-ai#3)

* Bump @azure/identity to 4.2.0

* Merge remote-tracking branch 'upstream/main' into add-aca-sessions
jacoblee93 pushed a commit that referenced this issue Oct 9, 2024
* examples & docs

* cr

* finished example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants