DynamicPrompt class creation #49
Conversation
sjwhitmore
force-pushed
the
samantha/dynamic_prompt
branch
from
85e9afb
to
d58f1d0
Compare
|
messed up the git state a bit initially but think i fixed it with the branch force push |
|
also added callable for returning length attribute of prompt |
sjwhitmore
changed the title
|
|
||
|
|
||
| class DynamicPrompt(BaseModel, BasePrompt): | ||
| r"""Schema to represent a dynamic prompt for an LLM. |
There was a problem hiding this comment.
ah i forgot the linter told me to do this
./langchain/prompt.py:133:1: D301 Use r""" if any backslashes in a docstring
| super super super super long, this will affect the example right?""" | ||
| test_short_question = "Short question?" | ||
|
|
||
| assert dynamic_prompt.format( |
There was a problem hiding this comment.
same comments here as above. maybe could do a helper function to factor out common stuff?
|
|
||
| def test_dynamic_prompt_trims_examples() -> None: | ||
| """Test dynamic prompt can be successfully constructed from examples.""" | ||
| longer_template = """Test Prompt: |
There was a problem hiding this comment.
this is a complete nit but i hate how this looks visually lol. i ran into this on prev prs - can we either put the prompt outside the test function OR do something like
shortest_template = (
"Test Prompt:\n"
"Question: {question}\n"
Answer:"
)
or is there a better way to do it? to be clear the part i dont like is the weird indent
There was a problem hiding this comment.
yes i agree! reformatted
Checking that this structure looks generally ok -- going to sub in logic where the TODO comment is then add a test.