Add query parsing unit tests #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
approved these changes
Apr 27, 2023
|
|
||
|
|
||
| def test_parse_string_value() -> None: | ||
| for x in ('""', '" "', '"foo"', "'foo'"): |
There was a problem hiding this comment.
Maybe it's possible to add extra information after the `assert actual == x[1:-1], details message' , so if one of the tests fails it's easy to determine which test- case it is? (or use pytest.mark.parameterize which does that)
|
|
||
|
|
||
| def test_parse_bool_value() -> None: | ||
| for y in ("true", "false"): |
There was a problem hiding this comment.
(style) this is definitely a matter of style, i tend to hard-code the constants for all the test-cases instead of relying on code, to keep the specification of the inputs into the test case as simple as possible
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.