Azure CosmosDB memory #3434
Merged
Azure CosmosDB memory #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev2049
reviewed
Apr 24, 2023
hwchase17
pushed a commit
that referenced
this pull request
Apr 25, 2023
Test for #3434 @eavanvalkenburg Initially, I was unaware and had submitted a pull request #3450 for the same purpose, but I have now repurposed the one I used for that. And it worked.
vowelparrot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Still needs docs, otherwise works.
vowelparrot
pushed a commit
that referenced
this pull request
Apr 26, 2023
Test for #3434 @eavanvalkenburg Initially, I was unaware and had submitted a pull request #3450 for the same purpose, but I have now repurposed the one I used for that. And it worked.
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
Still needs docs, otherwise works.
vowelparrot
pushed a commit
that referenced
this pull request
Apr 28, 2023
Test for #3434 @eavanvalkenburg Initially, I was unaware and had submitted a pull request #3450 for the same purpose, but I have now repurposed the one I used for that. And it worked.
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Still needs docs, otherwise works.
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Test for langchain-ai#3434 @eavanvalkenburg Initially, I was unaware and had submitted a pull request langchain-ai#3450 for the same purpose, but I have now repurposed the one I used for that. And it worked.
yanghua
pushed a commit
to yanghua/langchain
that referenced
this pull request
May 9, 2023
Still needs docs, otherwise works.
yanghua
pushed a commit
to yanghua/langchain
that referenced
this pull request
May 9, 2023
Test for langchain-ai#3434 @eavanvalkenburg Initially, I was unaware and had submitted a pull request langchain-ai#3450 for the same purpose, but I have now repurposed the one I used for that. And it worked.
|
I tested according to the test case here, and I found that the problem is that once CosmosDBChatMessageHistory is called again, it will overwrite the previously saved conversation history, resulting in no historical conversation and no data insertion from the historical conversation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still needs docs, otherwise works.