Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep Lake mini upgrades #3375

Merged
merged 49 commits into from
Apr 24, 2023
Merged

Deep Lake mini upgrades #3375

merged 49 commits into from
Apr 24, 2023

Conversation

davidbuniat
Copy link
Contributor

@davidbuniat davidbuniat commented Apr 23, 2023

Improvements

  • set default num_workers for ingestion to 0
  • upgraded notebooks for avoiding dataset creation ambiguity
  • added force_delete_dataset_by_path
  • bumped deeplake to 3.3.0
  • creds arg passing to deeplake object that would allow custom S3

Notes

  • please double check if poetry is not messed up (thanks!)

Asks

  • Would be great to create a shared slack channel for quick questions

Copy link

@aiswaryasankar aiswaryasankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few small comments - overall question though, I see that this adds the overwrite=True as the default option but does it address the concern of hitting Please use a url that points to an existing Deep Lake Dataset or an empty folder. If you wish to delete the folder and its contents, you may run deeplake.delete(dataset_path, force=True) when the dataset upload failed for some reason. I think probably another fix might be needed to fix that issue.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit 2c00233 into langchain-ai:master Apr 24, 2023
vowelparrot pushed a commit that referenced this pull request Apr 26, 2023
Improvements
* set default num_workers for ingestion to 0
* upgraded notebooks for avoiding dataset creation ambiguity
* added `force_delete_dataset_by_path`
* bumped deeplake to 3.3.0
* creds arg passing to deeplake object that would allow custom S3

Notes
* please double check if poetry is not messed up (thanks!)

Asks
* Would be great to create a shared slack channel for quick questions

---------

Co-authored-by: Davit Buniatyan <d@activeloop.ai>
vowelparrot pushed a commit that referenced this pull request Apr 28, 2023
Improvements
* set default num_workers for ingestion to 0
* upgraded notebooks for avoiding dataset creation ambiguity
* added `force_delete_dataset_by_path`
* bumped deeplake to 3.3.0
* creds arg passing to deeplake object that would allow custom S3

Notes
* please double check if poetry is not messed up (thanks!)

Asks
* Would be great to create a shared slack channel for quick questions

---------

Co-authored-by: Davit Buniatyan <d@activeloop.ai>
samching pushed a commit to samching/langchain that referenced this pull request May 1, 2023
Improvements
* set default num_workers for ingestion to 0
* upgraded notebooks for avoiding dataset creation ambiguity
* added `force_delete_dataset_by_path`
* bumped deeplake to 3.3.0
* creds arg passing to deeplake object that would allow custom S3

Notes
* please double check if poetry is not messed up (thanks!)

Asks
* Would be great to create a shared slack channel for quick questions

---------

Co-authored-by: Davit Buniatyan <d@activeloop.ai>
yanghua pushed a commit to yanghua/langchain that referenced this pull request May 9, 2023
Improvements
* set default num_workers for ingestion to 0
* upgraded notebooks for avoiding dataset creation ambiguity
* added `force_delete_dataset_by_path`
* bumped deeplake to 3.3.0
* creds arg passing to deeplake object that would allow custom S3

Notes
* please double check if poetry is not messed up (thanks!)

Asks
* Would be great to create a shared slack channel for quick questions

---------

Co-authored-by: Davit Buniatyan <d@activeloop.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants