Skip to content

core[patch]: WIP tools correctly handle injectable params in custom args schema #31687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

core[patch]: WIP tools correctly handle injectable params in custom args schema #31687

wants to merge 4 commits into from

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Jun 20, 2025 •
edited
Loading

  • Add a unit test to show failing test case
  • Add documentation to clarify semantics

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 5:18pm

@eyurtsev eyurtsev changed the title core[patch]: WIP correctly handle injectable params in custom args schema core[patch]: WIP tools correctly handle injectable params in custom args schema Jun 20, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed WallTime Performance Report

Merging #31687 will not alter performance

Comparing eugene/update_tools_schema (fd532c6) with master (7ff4050)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jun 20, 2025

CodSpeed Instrumentation Performance Report

Merging #31687 will not alter performance

Comparing eugene/update_tools_schema (fd532c6) with master (7ff4050)

Summary

✅ 13 untouched benchmarks

@nfcampos nfcampos linked an issue Jun 20, 2025 that may be closed by this pull request
When using custom input schema on tool, the state is not being injected #31688
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When using custom input schema on tool, the state is not being injected
1 participant
@eyurtsev