Skip to content

langchain-text-splitters: Reverse preserved elements iterator in HTMLSemanticPreservingSplitter #31570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

strawgate
Copy link

Reverse preserved elements iterator to fix

#31568

Copy link

vercel bot commented Jun 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2025 6:07pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: text splitters Related to text splitters package 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Jun 11, 2025
Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Walltime Performance Report

Merging #31570 will not alter performance

Comparing strawgate:patch-1 (2941271) with master (446a9d5)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

Copy link

codspeed-hq bot commented Jun 11, 2025

CodSpeed Instrumentation Performance Report

Merging #31570 will not alter performance

Comparing strawgate:patch-1 (2941271) with master (446a9d5)

Summary

✅ 13 untouched benchmarks

@eyurtsev
Copy link
Collaborator

Could you add a unit test?

@eyurtsev eyurtsev self-assigned this Jun 20, 2025
@eyurtsev eyurtsev added the needs test PR needs to be updated with tests label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature needs test PR needs to be updated with tests size:XS This PR changes 0-9 lines, ignoring generated files. Ɑ: text splitters Related to text splitters package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants