core: Fix issue 31035 alias fields in base tool langchain core #31112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because the `inspect` method is used to collect annotations for fields we need this mapping since this method returns aliases of the fields and not the original field name
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:S
4 tasks
ccurme
approved these changes
May 11, 2025
dosubot
bot
added
the
lgtm
| # Gather pydantic field objects (v2: model_fields / v1: __fields__) | ||
| fields = getattr(cls, "model_fields", {}) or getattr(cls, "__fields__", {}) | ||
| alias_map = {field.alias: name for name, field in fields.items() if field.alias} | ||
|
|
||
| annotations: dict[str, type] = {} | ||
| for name, param in inspect.signature(cls).parameters.items(): |
There was a problem hiding this comment.
For pydantic models, why not just look in model_fields directly? Why go through all of the signature / special casing logic?
There was a problem hiding this comment.
Seems like a fine bandaid until we drop v1 support
ccurme
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The 'inspect' package in python skips over the aliases set in the schema of a pydantic model. This is a workound to include the aliases from the original input.
issue: #31035
Cc: @ccurme @eyurtsev