Skip to content

Core: Not using Alias when it is set for field in Pydantic Model Arg Schema for Tool #31036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Core: Not using Alias when it is set for field in Pydantic Model Arg Schema for Tool #31036

wants to merge 16 commits into from

Conversation

keenborder786
Copy link
Contributor

@keenborder786 keenborder786 commented Apr 26, 2025 •
edited
Loading

Issue: #31035
Description: Rather than using Alias, we use the actual attribute name.

@vercel Vercel
Copy link

vercel bot commented Apr 26, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview May 4, 2025 0:46am

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. langchain Related to the langchain package 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature labels Apr 26, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 26, 2025
@keenborder786 keenborder786 changed the title Fix/pydantic get all basemodel annotations Core: Added Warning in case Alias is set for field in Pydantic Model Arg Schema for Tool Apr 26, 2025
@keenborder786
Copy link
Contributor Author

@ccurme

1 similar comment
@keenborder786
Copy link
Contributor Author

@ccurme

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 4, 2025
@keenborder786 keenborder786 changed the title Core: Added Warning in case Alias is set for field in Pydantic Model Arg Schema for Tool Core: Not using Alias when it is set for field in Pydantic Model Arg Schema for Tool May 4, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 4, 2025
@keenborder786
Copy link
Contributor Author

@cccs-eric @efriis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature langchain Related to the langchain package size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@keenborder786