langchain[patch]: Allow async indexing code to work for vectorstores that only defined sync delete #30869
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`aindex` function should check not only `adelete` method, but `delete` method too
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
|
Failed test doesn't apply to the modified code |
|
Can someone check this PR please? |
eyurtsev
changed the title
|
Thank you @shkarupa-alex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aindexfunction should check not onlyadeletemethod, butdeletemethod tooPR title: "core: fix async indexing issue with adelete/delete checking"
PR message: Currently
langchain.indexes.aindexchecks if vector store has overrided adelete method. But due toadeletedefault implementation store can have justdeleteoverrided to makeadeleteworking.