Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Anthropic] Shallow Copy #27105

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[Anthropic] Shallow Copy #27105

merged 3 commits into from
Oct 15, 2024

Conversation

hinthornw
Copy link
Collaborator

No description provided.

@efriis efriis added the partner label Oct 4, 2024
@efriis efriis self-assigned this Oct 4, 2024
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 4, 2024
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Oct 15, 2024 3:48pm

@hinthornw hinthornw requested a review from efriis October 4, 2024 14:42
@dosubot dosubot bot added the 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Oct 4, 2024
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -139,12 +139,12 @@ def _merge_messages(
if isinstance(last.content, str):
new_content: List = [{"type": "text", "text": last.content}]
else:
new_content = last.content
new_content = copy.copy(last.content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably still be last.content

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Oct 4, 2024
@efriis efriis enabled auto-merge (squash) October 15, 2024 15:48
@efriis efriis merged commit 0a3e089 into master Oct 15, 2024
26 checks passed
@efriis efriis deleted the wfh/shallow branch October 15, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs partner size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants