Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove [project] tag from pyproject #26633

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

efriis
Copy link
Member

@efriis efriis commented Sep 18, 2024

makes core incompatible with uv installs

Copy link

vercel bot commented Sep 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:39pm

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 18, 2024
@eyurtsev
Copy link
Collaborator

cc @cbornet the tag was breaking docs build with uv

@efriis efriis enabled auto-merge (squash) September 18, 2024 20:29
@efriis
Copy link
Member Author

efriis commented Sep 18, 2024

comment in #26608

@efriis efriis merged commit 84b8313 into master Sep 18, 2024
98 checks passed
@efriis efriis deleted the erick/core-remove-project-tag-from-pyproject branch September 18, 2024 20:39
@efriis
Copy link
Member Author

efriis commented Sep 18, 2024

looks like recommendation is to use tool.ruff target-version! https://docs.astral.sh/ruff/settings/#target-version

Sheepsta300 pushed a commit to Sheepsta300/langchain that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants