Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Include global variables in variables found by get_function_nonlocals #25936

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

nfcampos
Copy link
Collaborator

@nfcampos nfcampos commented Sep 2, 2024

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
  • PR message: Delete this entire checklist and replace with

    • Description: a description of the change
    • Issue: the issue # it fixes, if applicable
    • Dependencies: any dependencies required for this change
    • Twitter handle: if your PR gets announced, and you'd like a mention, we'll gladly shout you out!
  • Add tests and docs: If you're adding a new integration, please include

    1. a test for the integration, preferably unit tests that do not rely on network access,
    2. an example notebook showing its use. It lives in docs/docs/integrations directory.
  • Lint and test: Run make format, make lint and make test from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Sep 2, 2024 6:37pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 2, 2024
@nfcampos nfcampos changed the title core: Include global variables in variables found by get_function_non_locals core: Include global variables in variables found by get_function_nonlocals Sep 2, 2024
@dosubot dosubot bot added langchain Related to the langchain package Ɑ: core Related to langchain-core labels Sep 2, 2024
@nfcampos nfcampos enabled auto-merge (squash) September 2, 2024 18:21
@nfcampos nfcampos disabled auto-merge September 2, 2024 18:49
@nfcampos nfcampos merged commit 464dae8 into master Sep 2, 2024
87 of 88 checks passed
@nfcampos nfcampos deleted the nc/2sep/core-nonlocals-include-globals branch September 2, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core langchain Related to the langchain package size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant