Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community[patch],core[patch]: Update EdenaiTool root_validator and add unit test in core #25233

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Aug 9, 2024

This PR gets rid root_validators(allow_reuse=True) logic used in EdenAI Tool in preparation for pydantic 2 upgrade.

  • add another test to secret_from_env_factory

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2024
Copy link

vercel bot commented Aug 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 3:47pm

@eyurtsev eyurtsev added 0.3 prep Work done for 0.3 prep and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 9, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) August 9, 2024 14:12
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 9, 2024
@eyurtsev eyurtsev merged commit b6f0174 into master Aug 9, 2024
112 checks passed
@eyurtsev eyurtsev deleted the eugene/community_clean_up_allow_reuse branch August 9, 2024 15:59
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
…d unit test in core (langchain-ai#25233)

This PR gets rid `root_validators(allow_reuse=True)` logic used in
EdenAI Tool in preparation for pydantic 2 upgrade.
- add another test to secret_from_env_factory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.3 prep Work done for 0.3 prep community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant