-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs]: update Redis (langchain-redis) documentation notebooks (vectorstore, llm caching, chat message history) #25113
[docs]: update Redis (langchain-redis) documentation notebooks (vectorstore, llm caching, chat message history) #25113
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for doing this. Some comments / questions:
- We recently introduced an effort to standardize our integration docs, including vector store docs. See issue here: Standardize vector store docs #24800. This PR recently standardized the redis vector store doc. We are un-doing some of that here.
- If possible we should update the existing caching doc instead of writing a new one for Redis.
- The changes to the vector store doc in particular remove what I'd consider useful sections (e.g., overview of deployment options, deploying via Docker, etc.). I'm wondering what is the motivation for deleting them. Left some comments in-line.
@ccurme some answers...
Sure, I'll check it the PR and adjust
Speaking with @efriis about the caching page...
I particularly felt there was too much ceremony before getting to the usage of the library, but I can bring some of that back. |
c3efb5e
to
f7eedd6
Compare
Looked at all the associated issues with standardizing the vectorstores docs, and modified the redis notebook to follow the guidelines. Another PR for the langchain-redis project with updated DocStrings will follow. Cheers. |
f7eedd6
to
3f441c0
Compare
LGTM from a Reids standpoint -- thanks @bsbodden ! |
@bsbodden
and@redis