Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[patch]: exclude special pydantic init params #25084

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

baskaryan
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Aug 5, 2024 11:25pm

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 5, 2024
@baskaryan baskaryan requested a review from eyurtsev August 5, 2024 22:19
@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:improvement Medium size change to existing code to handle new use-cases labels Aug 5, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Aug 5, 2024
@baskaryan baskaryan enabled auto-merge (squash) August 5, 2024 23:24
@baskaryan baskaryan merged commit e572521 into master Aug 5, 2024
164 checks passed
@baskaryan baskaryan deleted the bagatur/fix_25072 branch August 5, 2024 23:32
@baskaryan
Copy link
Collaborator Author

baskaryan commented Aug 6, 2024

Fixes #25072

ccurme added a commit that referenced this pull request Aug 6, 2024
Among integration packages in libs/partners, Groq is an exception in
that it errors on warnings.

Following #25084, Groq
fails with

> pydantic.warnings.PydanticDeprecatedSince20: The `__fields__`
attribute is deprecated, use `model_fields` instead. Deprecated in
Pydantic V2.0 to be removed in V3.0.

Here we update the behavior to no longer fail on warning, which is
consistent with the rest of the packages in libs/partners.
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
Among integration packages in libs/partners, Groq is an exception in
that it errors on warnings.

Following langchain-ai#25084, Groq
fails with

> pydantic.warnings.PydanticDeprecatedSince20: The `__fields__`
attribute is deprecated, use `model_fields` instead. Deprecated in
Pydantic V2.0 to be removed in V3.0.

Here we update the behavior to no longer fail on warning, which is
consistent with the rest of the packages in libs/partners.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ɑ: core Related to langchain-core 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants