Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core[patch]: Fix word spelling error in globals.py #24532

Merged
merged 4 commits into from
Jul 23, 2024
Merged

core[patch]: Fix word spelling error in globals.py #24532

merged 4 commits into from
Jul 23, 2024

Conversation

ZhangShenao
Copy link
Contributor

Fix word spelling error in globals.py

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 23, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 2:16pm

@dosubot dosubot bot added Ɑ: core Related to langchain-core 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jul 23, 2024
@ZhangShenao ZhangShenao reopened this Jul 23, 2024
@ZhangShenao ZhangShenao reopened this Jul 23, 2024
@ZhangShenao
Copy link
Contributor Author

The failure in unit test doesn't seem to caused by this change:

=========================== short test summary info ============================
ERROR tests/unit_tests/graph_vectorstores/extractors/test_hierarchy_link_extractor.py
ERROR tests/unit_tests/graph_vectorstores/extractors/test_html_link_extractor.py
ERROR tests/unit_tests/graph_vectorstores/extractors/test_link_extractor_transformer.py
!!!!!!!!!!!!!!!!!!! Interrupted: 3 errors during collection !!!!!!!!!!!!!!!!!!!!
=================== 3 skipped, 3 warnings, 3 errors in 3.49s ===================

@efriis

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 23, 2024
@eyurtsev eyurtsev self-assigned this Jul 23, 2024
@eyurtsev eyurtsev changed the title [Format] Fix word spelling error in globals.py core[patch]: Fix word spelling error in globals.py Jul 23, 2024
@eyurtsev eyurtsev enabled auto-merge (squash) July 23, 2024 14:16
@eyurtsev eyurtsev merged commit a14e02a into langchain-ai:master Jul 23, 2024
97 checks passed
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
@ZhangShenao @eyurtsev @olgamurraft
core[patch]: Fix word spelling error in globals.py (langchain-ai#24532
d6ac4f9 
)

Fix word spelling error in `globals.py`

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
Ɑ: core Related to langchain-core lgtm PR looks good. Use to confirm that a PR is ready for merging. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZhangShenao @eyurtsev