Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cosmosdbnosql: Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook #24424

Open
wants to merge 60 commits into
base: master
Choose a base branch
from
Open

cosmosdbnosql: Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook #24424

wants to merge 60 commits into from
+512 −59

Conversation

gsa9989
Copy link

@gsa9989 gsa9989 commented Jul 19, 2024

  • Added Cosmos DB NoSQL Semantic Cache Integration with tests and jupyter notebook

@vercel Vercel
Copy link

vercel bot commented Jul 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 7:46pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases labels Jul 19, 2024
@gsa9989
Copy link
Author

gsa9989 commented Aug 1, 2024

@ccurme can you please review this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Aug 7, 2024
@jcodella
Copy link

Friendly ping @ccurme for a review here

ccurme
ccurme reviewed Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping.

See our contributing guidelines for how to format and lint code locally for future commits. I ran the formatter myself for now but there are still some type issues, would you mind taking a look? https://github.com/langchain-ai/langchain/actions/runs/10582689581/job/29323028501?pr=24424

The PR summary mentions a notebook, but I don't see any updates to documentation here. I think this would be good to add, otherwise the new cache will not be discoverable. If you edit docs/docs/integrations/llm_caching.ipynb, it will get built into the docs preview here. Let me know if you have any questions!

libs/community/langchain_community/cache.py Outdated Show resolved Hide resolved
libs/community/langchain_community/cache.py Outdated Show resolved Hide resolved
libs/community/tests/integration_tests/cache/test_azure_cosmosdbnosql_cache.py Outdated Show resolved Hide resolved
@ccurme ccurme self-assigned this Aug 27, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@aayush3011
Copy link
Contributor

aayush3011 commented Sep 25, 2024 •
edited
Loading

@ccurme Sorry, the PR fell through cracks. I have added the notebook please review.

@aayush3011
Copy link
Contributor

@ccurme Friendly ping on the status of the PR.

@aayush3011
Copy link
Contributor

Friendly ping @ccurme for a review here

@aayush3011
Copy link
Contributor

Friendly ping @isahers1 @baskaryan for a review here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aayush3011 aayush3011 aayush3011 left review comments

@ccurme ccurme ccurme left review comments

Assignees

@ccurme ccurme

Labels
community Related to langchain-community 🤖:improvement Medium size change to existing code to handle new use-cases size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
PR Reviews
Status: Needs support
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsa9989 @jcodella @aayush3011 @ccurme